Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.x][BuildRules] Various fixes #9349

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

smuzaffar
Copy link
Contributor

backport of #9344

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2024

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_0_X/master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

test parameters:

  • addpkg = FWCore, HeterogeneousCore

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_14_0_MULTIARCHS_X

@cms-sw cms-sw deleted a comment from cmsbuild Aug 5, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-29fd24/40770/summary.html
COMMIT: 2151063
CMSSW: CMSSW_14_0_X_2024-08-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9349/40770/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 12 lines to the logs
  • Reco comparison results: 46 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3343220
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3343194
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-29fd24/40777/summary.html
COMMIT: 2151063
CMSSW: CMSSW_14_0_MULTIARCHS_X_2024-08-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9349/40777/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 384 lines from the logs
  • Reco comparison results: 70904 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3343220
  • DQMHistoTests: Total failures: 228613
  • DQMHistoTests: Total nulls: 273
  • DQMHistoTests: Total successes: 3114314
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.02099999999999902 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 13034.0 ): 3.769 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 140.043,... ): -0.008 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 140.063 ): -0.012 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044 ): 0.094 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.046 ): 0.020 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): -0.303 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.225 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): 1.533 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): -4.839 KiB SiStrip/MechanicalView
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 15 / 46 workflows

@smuzaffar
Copy link
Contributor Author

+externals

@smuzaffar smuzaffar merged commit de9fcd6 into IB/CMSSW_14_0_X/master Aug 12, 2024
16 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar deleted the smuzaffar-patch-10 branch August 13, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants