CepGen spec-file #8023
CepGen spec-file #8023
Conversation
Cloned from CLHEP spec-file
|
A new Pull Request was created by @forthommel (Laurent Forthomme) for branch IB/CMSSW_12_5_X/master. @cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. |
|
assign generators |
|
New categories assigned: generators @mkirsano,@menglu21,@alberto-sanchez,@SiewYan,@GurpreetSinghChahal,@Saptaparna you have been requested to review this Pull request/Issue and eventually sign? Thanks |
|
@forthommel , In order tolet scram use it, you also need to add I will start the tests once @cms-sw/generators-l2 approves the inclusion of this generator in cmssw |
|
Oh good, many thanks for the pointers @smuzaffar ! As this is my first spec-file in a while (for RPM) and first ever (for cms-dist) I am not sure what is the exact procedure. Thanks ! |
|
Pull request #8023 was updated. |
forthommel
force-pushed
the
IB/CMSSW_12_5_X/master
branch
from
b00f2a2 to
8935372
Compare
|
Pull request #8023 was updated. |
|
please test |
|
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01fa2c/26897/summary.html External BuildI found compilation warning when building: See details on the summary page. |
Co-authored-by: Malik Shahzad Muzaffar <[email protected]>
|
Pull request #8023 was updated. |
Added useful interfacing libraries for HepMC2 (event output), LHAPDF (partonic photon PDF), and Pythia 6 ("legacy" proton remnant dissociation).
|
Pull request #8023 was updated. |
|
Hi @smuzaffar, just wondering whether there is a potential "snake biting its tail" issue for this integration? Is a CMSSW consumer code required to properly merge this? |
|
@forthommel , we need @cms-sw/generators-l2 approval first. If |
|
Very good, many thanks for the clarification @smuzaffar ! |
|
+1 |
|
please test for el8_aarch64_gcc10 |
|
please test for el8_ppc64le_gcc10 |
|
please test |
|
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Unit TestsI found errors in the following unit tests: ---> test TestFWCoreServicesDriver had ERRORS ---> test DRNTest had ERRORS |
|
@smuzaffar it looks like this |
|
@forthommel , yes cmssw errors are not related to this PR as nothing is cmssw should be using the new tool. I am just making sure that latest changes here still build on non-x86_64 archs |
|
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Unit TestsI found errors in the following unit tests: ---> test DRNTest had ERRORS |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01fa2c/27521/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
|
+externals |
cmsbuild
added
externals-approved
fully-signed
and removed
externals-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_6_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
Many thanks for all your effort, @smuzaffar ! I will now concentrate on the corresponding CMSSW package that follows. |
Adding a build recipe for CepGen, directly cloned from CLHEP CMake-based spec-file.
Already part of LCG102 release since integration of lcgcmake#1290.