Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR profiling: keep SQL file generated by igprof-analyze #1975

Merged
merged 2 commits into from
May 1, 2023

Conversation

gartung
Copy link
Member

@gartung gartung commented Apr 29, 2023

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for branch master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@gartung
Copy link
Member Author

gartung commented Apr 29, 2023

please test with cms-sw/cmssw#41374

@gartung
Copy link
Member Author

gartung commented Apr 29, 2023

enable profiling

@cmsbuild
Copy link
Contributor

Pull request #1975 was updated.

@gartung
Copy link
Member Author

gartung commented Apr 29, 2023

@smuzaffar

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmssw#41374

@smuzaffar
Copy link
Contributor

@gartung , looks good. Is it ready to go in?

@gartung
Copy link
Member Author

gartung commented May 1, 2023

yes

@smuzaffar smuzaffar merged commit 339e839 into cms-sw:master May 1, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c0862/32280/summary.html
COMMIT: f7fa46a
CMSSW: CMSSW_13_1_X_2023-05-01-1100/el8_amd64_gcc11
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/1975/32280/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 46 lines from the logs
  • Reco comparison results: 5208 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460877
  • DQMHistoTests: Total failures: 42821
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3418034
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants