Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add labeling for tracking #1916

Merged
merged 4 commits into from
Jan 18, 2023
Merged

add labeling for tracking #1916

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
875e901
add labeling for tracking
slava77 Jan 18, 2023
847bb9c
syntax
slava77 Jan 18, 2023
f2c36cc
not just reco
slava77 Jan 18, 2023
9d8c766
add BeamSpot and a few more to tracking, future-proof use just the be…
slava77 Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion categories_map.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1711,6 +1711,15 @@
#explicit `type label`. Only valid dpg/pog groups can be added as labels
#Format: label = [cmssw_pkg1, cmssw_pkgN]
#where cmssw_pkgX can be full or part of start of cmssw Package name
# "jetmet" = [ "SubSystem1", "SubSystem2/Package"]
# "jetmet": [ "SubSystem1", "SubSystem2/Package"]
CMSSW_LABELS = {
"tracking": [
"CUDADataFormats/Track",
"DataFormats/Track",
"RecoPixelVertexing",
"RecoTracker",
"RecoVertex",
"TrackPropagation",
"TrackingTools"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we need also RecoPixelVZero and RecoVZero (do not exist anymore since a long time).
Do we need to flag also non reconstruction packages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to flag also non reconstruction packages?

good point, here is more that matches

  • CUDADataFormats/Vertex
  • DataFormats/VertexReco
  • DQM/Tracking
  • Validation/RecoPixelVertexing
  • Validation/RecoTrack
  • Validation/RecoVertex
  • Validation/Tracking
  • FastSimulation/Tracking
  • Geometry/GlobalTracking

what else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we need also RecoPixelVZero and RecoVZero (do not exist anymore since a long time).

these were apparently removed in 9_2_X ( cms-sw/cmssw#18623) 10_0_X (cms-sw/cmssw#21456), respectively
But I guess I can add these as well

Copy link
Contributor

@mmusich mmusich Jan 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add:

  • CondFormats/BeamSpotObjects
  • AnalysisDataFormats/TrackInfo
  • CondCore/BeamSpotPlugins
  • CondFormats/BeamSpotObjects
  • CondTools/BeamSpot
  • DQM/BeamMonitor
  • Validation/TrackingMCTruth (already covered above)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add:

now in f2c36cc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually in 9d8c766

]
}