Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gevent and greenlet #1255

Merged
merged 3 commits into from
Feb 11, 2024
Merged

Upgrade gevent and greenlet #1255

merged 3 commits into from
Feb 11, 2024

Conversation

wil93
Copy link
Member

@wil93 wil93 commented Feb 8, 2024

Updating these two to the oldest versions that still successfully build on a Mac M1, mostly just for ease of testing, so I don't have to spin up a linux VM every time. (I still have issues with fp-compiler but that isn't critical).

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f736a2) 69.73% compared to head (7868bdd) 69.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1255      +/-   ##
==========================================
- Coverage   69.73%   69.42%   -0.31%     
==========================================
  Files         328      328              
  Lines       26201    26201              
==========================================
- Hits        18271    18191      -80     
- Misses       7930     8010      +80     
Flag Coverage Δ
functionaltests 46.96% <ø> (-0.56%) ⬇️
unittests 56.80% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wil93 wil93 marked this pull request as ready for review February 8, 2024 19:40
@stefano-maggiolo
Copy link
Member

I vaguely remember some reason to keep gevent pinned to 1.5, but tbh I can't remember which. If tests are passing I guess that's fine

@wil93
Copy link
Member Author

wil93 commented Feb 8, 2024

It seems I can run the tests successfully even with the latest versions available as of today (gevent 23.9.1 and greenlet 3.0.3), maybe we can upgrade to those versions instead?

@wil93 wil93 merged commit 1e0df35 into master Feb 11, 2024
@wil93 wil93 deleted the upg_gevent branch February 11, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants