Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XGBoost Photon MVA files version 2 #15

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

smorovic
Copy link
Contributor

Including newest model files retrained on Winter2024 HGG sample and 14_0_X.

This is the final version intended for inclusion of MVA diphoton HLT Path with CMSSW_14_0_X.
Pull requests for CMSSW master and 14_0_X will be opened as well to update default parameters and add unit tests.

Retrained on Winter2024 HGG sample and 14_0_X.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smorovic for branch master.

@cmsbuild, @jfernan2, @smuzaffar, @aandvalenzuela, @iarspider, @mandrenguyen can you please review it and eventually sign? Thanks.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2024

cms-bot internal usage

@mmusich
Copy link

mmusich commented Apr 12, 2024

test parameters:

@mmusich
Copy link

mmusich commented Apr 12, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a30c8d/38810/summary.html
COMMIT: 0a706d6
CMSSW: CMSSW_14_1_X_2024-04-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/RecoEgamma-PhotonIdentification/15/38810/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 115 lines to the logs
  • Reco comparison results: 41 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3316263
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3316243
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

REMINDER @rappoccio, @antoniovilela, @sextonkennedy: This PR was tested with cms-sw/cmssw#44719, please check if they should be merged together

@mmusich
Copy link

mmusich commented Apr 12, 2024

@jfernan2, as you signed cms-sw/cmssw#44719, can you please sign also this one (corresponding external update)?

@cmsbuild
Copy link
Contributor

REMINDER @antoniovilela, @rappoccio, @sextonkennedy: This PR was tested with cms-sw/cmssw#44720, please check if they should be merged together

@antoniovilela
Copy link

+1

@antoniovilela
Copy link

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants