Allow Event-based Input Skim with das-up-to-nevents.py
#131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are the checks failures related to the PR? It seems not to me. |
AdrianoDee
force-pushed
the
events_skim
branch
2 times, most recently
from
84f3a2f to
18d0a9e
Compare
AdrianoDee
force-pushed
the
events_skim
branch
from
92967c9 to
9bc0bfd
Compare
|
Hi Geovanny, I've teste with my local setup (using your instructions) and now everything works as it should. |
ggonzr
requested changes
Oct 21, 2024
There was a problem hiding this comment.
This patch works as expected. I created this RelVal and the new script is loaded in the cmsDriver.py command as required. I suggest a simple change to avoid potential exceptions
Co-authored-by: Geovanny González-Rodríguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With cms-sw/cmssw#45055 we can run data wfs skimming the input based on a maximum number of events (and relying on the golden data certification json). This PR proposes a way to allow the RelVal machine to use this new feature when the
InputInfoincludes a limit onevents(and no limit on lumisections or runs).