Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fixes for displaced tracking in #304 #309

Merged
merged 8 commits into from
Feb 12, 2025

Conversation

aehart
Copy link

@aehart aehart commented Feb 11, 2025

PR description:

This PR includes a few more fixes for #304 to restore the tracking efficiency as reported by the CI tests. In particular:

  • With the HYBRID algorithm, each MP now writes to two FM memories, destined to be read by the two combined TBs. However, with the HYBRID_DISPLACED algorithm, we have not yet combined the TBs for the triplet seeds, so this PR has each MP write FMs for the triplet seeds into dedicated memories, separate from the two used for prompt seeds.
  • We do not yet merge the TPAR or TPROJ memories for the triplet seeds, so this PR removes the pages in the TPROJ memories for the triplet seeds that otherwise cause excessive truncation.
  • The wiring for the HYBRID_DISPLACED algorithm has been updated to be based on the most recent version of the HYBRID wiring.

Some code cleanup is also included, such as removing obsolete settings/methods and adding useful warnings.

PR validation:

I have already run the CI tests with these changes, and the HYBRID_DISPLACED algorithm now passes with a reported tracking efficiency of 97.24%. I also ran the usual code formatting tools.

@aehart aehart requested a review from aryd February 11, 2025 11:30
Copy link

@aryd aryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me.

@aryd aryd merged commit 3472dd7 into MultipleMPs_Rebase2_squashed Feb 12, 2025
1 check failed
@aehart aehart deleted the more_displaced_fixes branch February 18, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants