Fix inventStubs bug in duplicate removal #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using L2L3D1 seeds, it is only L2L3 that are used to determined the r-z helix params, not L2D1 as the code currently assumes.
sarafiorendi
approved these changes
Apr 8, 2024
aryd
added a commit
that referenced
this pull request
Jun 11, 2024
* Andrews KF crash fix (#263) * Add z0 resolution to performance printout (#264) * Add z0 resolution to performance printout * code format * DR: fix displaced track bug & disable binning (#266) * Disable binning in DR * bug fix * add comment * code format * tweak comment * fix previous erroneous commit * DUMMY COMMIT BEFORE PR TO CENTRAL CMSSW * Run combined modules by default (#265) * Make combined modules default * tweak * Improve USEHYBRID ifdef range * Fix compiler error for pure Tracklet algo * Move fitpattern.txt refs, so only used for pure Tracklet algo * code format * Numerical stability fix (#269) * Made calculations more numerically stable. * Explicitly restrict to domain of asin/acos. * Added comments. * Code format. * Fixed typos in comments. * Only do calculations when needed. * Added const where applicable. * Fix inventStubs bug in duplicate removal (#271) * Fix inventStubs bug in duplicate removal When using L2L3D1 seeds, it is only L2L3 that are used to determined the r-z helix params, not L2D1 as the code currently assumes. * Update PurgeDuplicate.cc * add comment * formatted * Manually incorporating DTC stub, TT stub changes to CMSSW 14 dev branch * First pass at removing non-combined modules * Removed unused iMath code * Avoid stale pointers on subsequent events * Cleaner MP pointer checks Full agreement with HLS (100 events L1PHIC - D5PHIC) * First code for a ProjectionCalculator module * Set of changes to make a configuration that uses the Projection Calculator module * Fix mistake in code merging * Changes needed for the VMSME Router module * Fully implementing VMSMERouter, VMRouterCM no longer producing VMMEStubs * Manually incorporating DTC stub, TT stub changes to CMSSW 14 dev branch * Readding TCBase, VMSMER compatible w/ updated stub format * Addressing comments, fixing code format * Removing unneeded diskpswrittenr variable * Removing unneeded + 1 to rbits in TP * Updates to make sure we don't have missing projections --------- Co-authored-by: Ian Tomalin <[email protected]> Co-authored-by: Andrew Hart <[email protected]> Co-authored-by: Anders <[email protected]> Co-authored-by: bryates <[email protected]>
dally96
pushed a commit
that referenced
this pull request
Dec 3, 2024
* Fix inventStubs bug in duplicate removal When using L2L3D1 seeds, it is only L2L3 that are used to determined the r-z helix params, not L2D1 as the code currently assumes. * Update PurgeDuplicate.cc * add comment * formatted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using L2L3D1 seeds, it is only L2L3 that are used to determined the r-z helix params, not L2D1 as the code currently assumes. This PR fixes this.
When run on ttbar+200PU, remaking the stubs using the CMSSW 13 stub window sizes, it reduces the track rate per event from 323 to 284.
When run on ttbar+200PU, using the existing stubs made with CMSSW 14 stub window sizes, it reduces the track rate per event from 294 to 268.
The efficiency on displaced muon MC is very slightly higher.
P.S. One can query if https://github.com/cms-L1TK/cmssw/blob/ianFixInventStubs/L1Trigger/TrackFindingTracklet/src/PurgeDuplicate.cc#L743 should be calling getInventedCoordsExtended() for the prompt seed types (0-7) that form part of the extended tracking. Though I think getInventedCoordsExtended() and getInventedCoords() should give the same results for these.