Hero of the Maghar Thrall Event #63
Conversation
|
"Sniffed flag for Mannoroth is 33555200. However UNIT_FLAG_NOT_SELECTABLE makes the animation from Thrall's Throw Doomhammer spell be invisible, so I had to remove that flag." Zone wide music, are you sure? Not just very big distance like in Darkmoon Faire or Lament of the Highborne, or Brewfest? Also zone wide emote? I have reason to believe it should be distance based, not zone based. Would be nice if you could verify that u can see the emote from furthest corner of nagrand. (Its easy to implement, but we encountered something similar in karazhan with animal boss so I need data :) ) Does thrall and garrosh by any chance have any unattackable flag? That would explain why 34410 cant hit him. 34410 Stacking issue has been given to @Warlockbugs and he will deal with it once he is again playing with stacking. Greeting in EAI is done using EVENT_T_OOC_LOS but only works for player at the moment. Should the eventuality arise and be needed for two creatures let me know. |
It's possible that it is just a very large range for both the music and text emote. To test it I need help from someone though. One need to turn in the quest and the other stay in a far away corner.
Yes, they both have UNIT_FLAG_OOC_NOT_ATTACKABLE. I removed it and it works. Would TRIGGERED_IGNORE_UNSELECTABLE_FLAG work for this spell too or is there another workaround? |
|
No, but its something to consider to be added with it :) Cos its not the first time I am seeing it. Blizzard has a different serverside setting it seems. I.e. something like "cant be hit by player, but can be hit by NPC stuff" and we dont have such capabilities at the moment. |
|
For Mannoroth TRIGGERED_IGNORE_UNSELECTABLE_FLAG worked like a charm. TRIGGERED_IGNORE_UNATTACKABLE_FLAG did not work for 34410. Neither Garrosh or Thrall got the buff. Strange thing is that even when I make them cast it themselves, either through dbscript or ingame with .cast back 34410 they still don't get affected. I guess UNIT_FLAG_OOC_NOT_ATTACKABLE is different from UNIT_FLAG_NOT_ATTACKABLE_1? |
|
So an update on the music. The range is all the way to where I am on the map below: Going further away than that, and it switches to normal nagrand music. I haven't looked into the emote and yell (I was only lucky to catch someone else start the event on retail), but I would assume their range is the same. Another question now is if it is solely a range check, cause in that case it will affect players in shattrath and zangarmarsh as well (since the origin is at the spawnpoint of thrall). Maybe there is a check for zone as well, so only players in Nagrand hears it? Needs some research... |
This is one of the longest events in WoW. It is based on this cinematic from WC3: https://www.youtube.com/watch?v=luuUE0x7-TY It starts after a player completes Hero of the Mag'har q.10212 (changed to There Is No Hope q.10172 in Cataclysm). The event will only run once every 6 hours. * Thrall, Drek'thar and an army of wolf riders spawn nearby Nesingwary Safari * They ride all the way to Garadar Gates where the riders form up outside and Thrall and Drek'thar continue inside Garadar. * Thrall goes to speak with Garrosh and Grandmother Geyah * Thrall and Garrosh go to the blue summoning ring where the main event takes part * After the event is finished Garrosh (or rather his buff bot triggers) buff all players and NPCs in Garadar with Hellscreams Warsong * After this Garrosh goes back to his spawn position and Thrall goes to Grandmother Geyah and sits there for 6 hours before despawning This closes: cmangos#63
Closes #24976 Credits, source & more info cmangos/tbc-db@b6e118e cmangos/tbc-db#63 Valid for master but instead the event should start after turning in 'There Is No Hope'
Closes #24976 Credits, source & more info cmangos/tbc-db@b6e118e cmangos/tbc-db#63 Valid for master but instead the event should start after turning in 'There Is No Hope' (cherry picked from commit 8c43aba)
Example vids for reference: https://www.youtube.com/watch?v=cuQCL7z9fMc , https://www.youtube.com/watch?v=VBiapet3a9g
This is the event that starts after a player turns in Hero of the Mag'har
Some notes:
Equipment is currently missing for some of the event NPCs.Solved with TBC - Equipment #58Implement variable length dbscript string logic mangos-tbc#174 needs to be implemented for this event to work. (For multiple creature_movement_template pathIds and for TRIGGERED_IGNORE_UNSELECTABLE_FLAG)Kor'kron Warrior/Honor Guards currently have their own separate paths. Once creature formations are implemented they should be divided into two groups with Honor guards in the middle:
Garadar Wolf Riders should possibly stop and greet Thrall if they run into him inside Garadar. I've been unable to confirm or witness this myself, and I'm not sure how that would be possible to implement anyways so it's left out for now.
Sniffed flag for Mannoroth is 33555200. However UNIT_FLAG_NOT_SELECTABLE makes the animation from Thrall's Throw Doomhammer spell be invisible, so I had to remove that flag.The buff casted by Garrosh's Buff Bots(34410) at the end of the event is stacking, so if you're standing close to more than one buff bot you will get duplicate buffs.
For some reason the buff casted by Garrosh's Buff Bots(34410) does not hit Thrall and Garrosh. Factions seem to be correct, so I'm not sure why it's not working.The maximum search distance for SCRIPT_COMMAND_TERMINATE_SCRIPT is 500y. Thrall spawns further away than that from the quest turn in, so it is possible for players to sometimes start the event again even if Thrall is already spawned.
The text emote on Thrall spawn ("War drums echo in the distance.") should be visible all the way to Garadar, but we have no zone wide text emote type.
The music should change to id 6146 when the event starts and stay that way until Thrall reaches Garrosh. Most likely this should be triggered by the NPC named Thrall's Hero Music (19597). However it is currently not possible to change the music zonewide, so for now Thrall is changing the music for those near him only.