Simplify App usage by making LoopInterface argument optional
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonFrings
approved these changes
Jun 18, 2021
Degra1991
approved these changes
Jun 18, 2021
This was referenced Jun 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset significantly simplifies
Appusage by makingLoopInterfaceargument optional. See updated documentation and tests to see how this makes using X much easier.Builds on top of reactphp/event-loop#226 which is currently untagged, so this temporarily references its
masterbranch. This will be released very soon, at which point we'll be able to target thev1.2.0version instead 👍