Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for HTTP redirecting #138

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Conversation

SimonFrings
Copy link
Contributor

This PR builds on top of #13 and #114.

Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thank you for looking into this, this looks like a nice addition! 👍

crawler receives a redirect, they will automatically follow the new URL provided
in the `Location` header.

See [response status codes](#status-codes) for more details.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a useful link, but perhaps we can make this more useful by providing more context, e.g. a list of common status codes for redirects?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a list with commonly used redirect status codes, WDYT?

@clue clue added the documentation Improvements or additions to documentation label Apr 23, 2022
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thank you for the update, keep it up! :shipit:

@clue clue merged commit 75c551f into clue:main Apr 29, 2022
@SimonFrings SimonFrings added this to the v0.9.0 milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants