Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

Partial fetch #76

Merged
merged 8 commits into from
Aug 25, 2021
Merged

Partial fetch #76

merged 8 commits into from
Aug 25, 2021

Conversation

michelvocks
Copy link
Contributor

@michelvocks michelvocks commented Aug 18, 2021 •
edited
Loading

Fixes #60

More information regarding backwards compatibility testing:

  • New Provider (AWS) compiled with this SDK version -> old CloudQuery CLI: ✅
  • New CloudQuery CLI compiled with this SDK version -> old provider (AWS): ✅

@michelvocks michelvocks requested a review from roneli August 18, 2021 13:42
@michelvocks michelvocks mentioned this pull request Aug 18, 2021
Merged
roneli
roneli suggested changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some edge cases we missed, I really liked the implementation

provider/schema/execution.go Show resolved Hide resolved
provider/schema/execution.go Show resolved Hide resolved
provider/schema/execution.go Outdated Show resolved Hide resolved
provider/schema/execution.go Show resolved Hide resolved
provider/schema/execution_test.go Outdated Show resolved Hide resolved
roneli
roneli approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, we just need to address the two final comments I believe, I will have another look at it after and we will be able to merge the PR.

roneli
roneli suggested changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment on logic flow of insert execution, and we can merge

provider/schema/execution.go Outdated Show resolved Hide resolved
roneli
roneli approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roneli roneli merged commit a6a6dbd into main Aug 25, 2021
@roneli roneli deleted the partial_fetch branch August 25, 2021 19:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roneli roneli roneli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature\Allow partial fetch
2 participants
@michelvocks @roneli