Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

fix: Null cq_id error #295

Merged
merged 1 commit into from
May 31, 2022
Merged

fix: Null cq_id error #295

merged 1 commit into from
May 31, 2022

Conversation

shimonp21
Copy link
Contributor

@shimonp21 shimonp21 commented May 30, 2022 •
edited
Loading

🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉

Summary

Fixes: https://github.com/cloudquery/cloudquery-issues/issues/352.

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests 🧪
  • Ensure the status checks below are successful ✅

@shimonp21 shimonp21 requested review from roneli and a team May 30, 2022 13:05
@github-actions github-actions bot added fix and removed fix labels May 30, 2022
roneli
roneli approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great catch, would suggest to add a test to make sure we don't have a regression.

@github-actions github-actions bot added fix and removed fix labels May 31, 2022
@shimonp21
Copy link
Contributor Author

Added test

@shimonp21 shimonp21 merged commit b41a56c into cloudquery:main May 31, 2022
@shimonp21 shimonp21 deleted the try_fix_nil_cq_id branch May 31, 2022 08:27
@cq-bot cq-bot mentioned this pull request May 31, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roneli roneli roneli approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shimonp21 @roneli