Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

feat: Improved execution logging #235

Merged
merged 10 commits into from
May 1, 2022

Conversation

roneli
Copy link
Contributor

@roneli roneli commented Apr 28, 2022

Execution Logger starts with "table" -> table base implied args, on each client execution we add clients implied args + client id.
On relations we add another With arg called relation. Might require some more tweaking

@roneli roneli requested a review from disq April 28, 2022 20:04
@roneli roneli force-pushed the feat/improved_logging branch from 6d27a22 to e904e0d Compare April 28, 2022 20:15
@roneli roneli changed the title Feat/improved logging feat: Improved execution logging Apr 28, 2022
@github-actions github-actions bot added the feat label Apr 28, 2022
@disq
Copy link
Member

disq commented Apr 28, 2022

I'm ok with this

@disq
Copy link
Member

disq commented Apr 29, 2022

doesn't really work {"@level":"info","@message":"fetched successfully","@module":"aws","@timestamp":"2022-04-29T09:05:24.759649+01:00","EXTRA_VALUE_AT_END":["AutoscalingNamespace","kafka","Region","ca-central-1","account_id","6157xxxxxxxx","client_id","aws_applicationautoscaling_policies:124"],"count":0,"table":"aws_applicationautoscaling_policies"}

@roneli
Copy link
Contributor Author

roneli commented May 1, 2022

doesn't really work {"@level":"info","@message":"fetched successfully","@module":"aws","@timestamp":"2022-04-29T09:05:24.759649+01:00","EXTRA_VALUE_AT_END":["AutoscalingNamespace","kafka","Region","ca-central-1","account_id","6157xxxxxxxx","client_id","aws_applicationautoscaling_policies:124"],"count":0,"table":"aws_applicationautoscaling_policies"}

fixed

@roneli roneli merged commit 66f762e into cloudquery:main May 1, 2022
@roneli roneli deleted the feat/improved_logging branch May 1, 2022 17:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants