Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

fix: Resolve column diags not returned #213

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

roneli
Copy link
Contributor

@roneli roneli commented Mar 23, 2022

No description provided.

@github-actions github-actions bot added the fix label Mar 23, 2022
@disq disq self-requested a review March 23, 2022 10:45
@disq
Copy link
Member

disq commented Mar 23, 2022

Consider deprecating WithNoOverwrite with:

Deprecated: Prefer using WithOptionalSeverity on the opposite side instead

Removing WithNoOverwrite would also simplify all the BaseOption fn bodies.

@disq disq merged commit 494dec3 into cloudquery:main Mar 23, 2022
@roneli roneli deleted the Fix/fix_resolve_columns_diags branch March 23, 2022 13:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants