Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

fix: Tool: Add param to run in TSDB mode without TSDB #204

Merged
merged 2 commits into from
Mar 14, 2022
Merged

fix: Tool: Add param to run in TSDB mode without TSDB #204

merged 2 commits into from
Mar 14, 2022

Conversation

disq
Copy link
Member

@disq disq commented Mar 14, 2022

No description provided.

@disq disq requested a review from roneli March 14, 2022 19:54
@github-actions github-actions bot added the fix label Mar 14, 2022
roneli
roneli approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would update docshttps://docs.cloudquery.io/docs/developers/sdk/migrations/generating-migrations on what flags to add for tsdb to generate on top of a vanilla pg.

@disq
Copy link
Member Author

disq commented Mar 14, 2022

Agreed, will add after it's settled (so, now probably)

@disq disq requested a review from bbernays March 14, 2022 20:55
@disq disq merged commit 40d5297 into main Mar 14, 2022
@disq disq deleted the fix/tool-history-override branch March 14, 2022 21:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roneli roneli roneli approved these changes

@bbernays bbernays bbernays approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@disq @bbernays @roneli