This repository has been archived by the owner on Aug 12, 2022. It is now read-only.
fix: Diagnostics should always include error message #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbernays
approved these changes
Mar 2, 2022
| @@ -60,7 +60,12 @@ func (e BaseError) Description() Description { | |||
| summary := e.summary | |||
| if e.summary == "" { | |||
| summary = e.Error() | |||
| } else if e.err != nil { | |||
| if es := e.err.Error(); es != summary { | |||
| summary += ": " + es | |||
There was a problem hiding this comment.
I am not sure about this, but is there ever a time we could have such deeply nested errors that the summary field overflows?
There was a problem hiding this comment.
I don’t think it’s an issue, there are definitely times when the err is too large (thats where the WithError will
come in with an updated/simplified underlying error, overridden by the error classifier… See my next gcp commit when I get back)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.