fix: IgnoreErrors were showing as warn and errors (#211)

* fix: IgnoreErrors were showing as warn and errors

* fix: Fix tests

.gitignore

@@ -3,3 +3,5 @@
 */.cq/*
 .cq/
 config.hcl
+
+.vscode

provider/execution/execution.go

@@ -228,9 +228,10 @@ func (e TableExecutor) callTableResolve(ctx context.Context, client schema.Clien
 		if err := e.Table.Resolver(ctx, client, parent, res); err != nil {
 			if e.Table.IgnoreError != nil && e.Table.IgnoreError(err) {
 				client.Logger().Warn("ignored an error", "err", err, "table", e.Table.Name)
-				err = diag.NewBaseError(err, diag.RESOLVING, diag.WithSeverity(diag.IGNORE), diag.WithSummary("table %q resolver ignored error", e.Table.Name))
+			} else {
+				resolverErr = e.handleResolveError(client, parent, err)
 			}
-			resolverErr = e.handleResolveError(client, parent, err)
+
 		}
 	}()
 

provider/execution/execution_test.go

@@ -274,16 +274,7 @@ func TestTableExecutor_Resolve(t *testing.T) {
 				Resolver: returnErrorResolver,
 				Columns:  commonColumns,
 			},
-			ErrorExpected: true,
-			ExpectedDiags: []diag.FlatDiag{
-				{
-					Err:      "some error",
-					Resource: "error_returning_ignore",
-					Severity: diag.IGNORE,
-					Summary:  `table "simple" resolver ignored error: some error`,
-					Type:     diag.RESOLVING,
-				},
-			},
+			ErrorExpected: false,
 		},
 		{
 			Name: "always_delete",

provider/provider_test.go

@@ -297,7 +297,6 @@ type FetchResourceTableTest struct {
 	ExpectedFetchResponses []*cqproto.FetchResourcesResponse
 	ExpectedError          error
 	MockStorageFunc        func(ctrl *gomock.Controller) *mock.MockStorage
-	PartialFetch           bool
 	ResourcesToFetch       []string
 	Context                func() context.Context
 }
@@ -326,17 +325,17 @@ func TestProvider_FetchResources(t *testing.T) {
 					Summary: cqproto.ResourceFetchSummary{
 						Status:        cqproto.ResourceFetchComplete,
 						ResourceCount: 0,
-						Diagnostics:   diag.Diagnostics{diag.NewBaseError(errors.New("bad error"), diag.RESOLVING, diag.WithResourceName("bad_resource_ignore_error"), diag.WithSeverity(diag.IGNORE), diag.WithSummary(`table "bad_resource_ignore_error" resolver ignored error`))},
+						Diagnostics:   diag.Diagnostics{},
 					},
 				}},
 			ExpectedError: nil,
 			MockStorageFunc: func(ctrl *gomock.Controller) *mock.MockStorage {
 				mockDB := mock.NewMockStorage(ctrl)
 				mockDB.EXPECT().Dialect().Return(schema.PostgresDialect{})
+				mockDB.EXPECT().RemoveStaleData(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(nil)
 				mockDB.EXPECT().Close()
 				return mockDB
 			},
-			PartialFetch:     true,
 			ResourcesToFetch: []string{"bad_resource_ignore_error"},
 		},
 		{
@@ -357,7 +356,6 @@ func TestProvider_FetchResources(t *testing.T) {
 				mockDB.EXPECT().Close()
 				return mockDB
 			},
-			PartialFetch:     false,
 			ResourcesToFetch: []string{"bad_resource"},
 		},
 		{