Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: Ignore role tags fetching when role does not exists #844

Merged

Conversation

zagronitay
Copy link
Contributor

@zagronitay zagronitay commented May 4, 2022

πŸŽ‰ Thank you for making CloudQuery awesome by submitting a PR πŸŽ‰

Summary

closes #843

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines πŸ§‘β€πŸŽ“
  • Run go fmt to format your code πŸ–Š
  • Update or add tests. Learn more about testing here πŸ§ͺ
  • Update the docs by running go run ./docs/docs.go and committing the changes πŸ“ƒ
  • If adding a new resource, add relevant Terraform files in a separate PR πŸ“‚
  • Ensure the status checks below are successful βœ…

@zagronitay zagronitay requested review from a team, shimonp21, bbernays, disq and irmatov and removed request for a team May 4, 2022 14:15
@github-actions github-actions bot added fix and removed fix labels May 4, 2022
Copy link
Contributor

@bbernays bbernays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roneli roneli merged commit 785a07a into cloudquery:main May 5, 2022
@zagronitay zagronitay deleted the fix/ignore-role-tags-no-such-entity branch May 25, 2022 09:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore NoSuchEntity for iam role tags
4 participants