This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
feat: Add tags to sns fetching #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#803 This adds an extra api call to retrieve the tags of each SNS topic.
andrewthetechie
requested review from
a team and
shimonp21
and removed request for
a team
|
@erezrokah here is my attempt at fixing #803 |
andrewthetechie
changed the title
roneli
reviewed
Apr 29, 2022
There was a problem hiding this comment.
Looks great, thanks for your contribution! ill let @erezrokah approve.
A few comments:
- run gofmt on your code so linter will pass
- execute https://github.com/cloudquery/cq-provider-aws/blob/main/docs/docs.go in your PR so docs will be regenerated and docs status check will pause
- Added 2 nits, but otherwise like looks good.
Co-authored-by: Ron <[email protected]>
roneli
approved these changes
May 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#803
This adds an extra api call to retrieve the tags of each SNS topic.