Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

Implement SSM documents resource #307

Merged
merged 18 commits into from
Nov 30, 2021
Merged

Implement SSM documents resource #307

merged 18 commits into from
Nov 30, 2021

Conversation

irmatov
Copy link
Contributor

@irmatov irmatov commented Nov 29, 2021

No description provided.

@irmatov irmatov marked this pull request as draft November 29, 2021 11:41
@irmatov irmatov marked this pull request as ready for review November 29, 2021 14:09
@irmatov irmatov requested a review from roneli November 29, 2021 14:10
roneli
roneli approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @zagronitay can you review the TF files?

CHANGELOG.md Outdated Show resolved Hide resolved
@roneli roneli requested a review from zagronitay November 29, 2021 15:05
zagronitay
zagronitay suggested changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@zagronitay zagronitay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

resources/integration_tests/aws_ssm_documents_test.go Show resolved Hide resolved
resources/integration_tests/infra/aws_ssm_documents.tf Outdated Show resolved Hide resolved
@zagronitay zagronitay merged commit 49bcd81 into cloudquery:main Nov 30, 2021
@irmatov irmatov deleted the ssm_documents branch December 1, 2021 10:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zagronitay zagronitay zagronitay requested changes

@roneli roneli roneli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irmatov @zagronitay @roneli