Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

Feat/sagemaker #291

Merged
merged 10 commits into from
Nov 25, 2021
Merged

Feat/sagemaker #291

merged 10 commits into from
Nov 25, 2021

Conversation

zagronitay
Copy link
Contributor

No description provided.

roneli
roneli suggested changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review, still need to go over training jobs

resources/sagemaker_endpoint_configurations.go Show resolved Hide resolved
resources/sagemaker_training_jobs.go Outdated Show resolved Hide resolved
resources/sagemaker_training_jobs.go Outdated Show resolved Hide resolved
roneli
roneli suggested changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, final comments on the training_jobs resource

resources/sagemaker_training_jobs.go Outdated Show resolved Hide resolved
resources/sagemaker_training_jobs.go Outdated Show resolved Hide resolved
resources/sagemaker_training_jobs.go Outdated Show resolved Hide resolved
roneli
roneli approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roneli roneli merged commit cdbdefa into cloudquery:main Nov 25, 2021
@zagronitay zagronitay deleted the feat/sagemaker branch May 3, 2022 14:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roneli roneli roneli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zagronitay @roneli