Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

Add RDS Cluster and DB snapshots and attributes #287

Merged
merged 6 commits into from
Nov 24, 2021
Merged

Add RDS Cluster and DB snapshots and attributes #287

merged 6 commits into from
Nov 24, 2021

Conversation

irmatov
Copy link
Contributor

@irmatov irmatov commented Nov 23, 2021

No description provided.

@irmatov irmatov requested review from amanenk and roneli November 23, 2021 11:06
roneli
roneli suggested changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, 1 change required, and e2e tests.

resources/rds_db_snapshots.go Outdated Show resolved Hide resolved
@irmatov irmatov requested a review from roneli November 23, 2021 14:17
roneli
roneli approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, add e2e tests and we can merge

@irmatov irmatov marked this pull request as draft November 24, 2021 06:57
@irmatov
Copy link
Contributor Author

irmatov commented Nov 24, 2021

e2e tests added

@irmatov irmatov marked this pull request as ready for review November 24, 2021 10:35
@roneli roneli merged commit c22a1eb into cloudquery:main Nov 24, 2021
@irmatov irmatov deleted the aws_rds_snapshots branch November 30, 2021 10:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roneli roneli roneli approved these changes

@amanenk amanenk Awaiting requested review from amanenk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irmatov @roneli