-
Notifications
You must be signed in to change notification settings - Fork 40
Conversation
Maybe add a unit test just for the resolver? The documentation (godoc) for the method needs more clarification or examples as well. |
# Conflicts: # client/mocks/glue.go # client/services.go
I like the resolver you added in this PR... My question looking at these fields is whether this is going to fetch too much data... as all of the nested calls are going to happen sequentially.... And looking at the Index/Partition data it doesn't seem that compliance/ security focused... |
# Conflicts: # client/mocks/glue.go # client/services.go # resources/services/glue/databases.go
@bbernays Agree on partitions. I have removed them. I have left indexes because it is infrastructural data that does not depend on data that is "fed" to glue |
Summary
closes #1368
closes #1366
Use the following steps to ensure your PR is ready to be reviewed
go fmt
to format your code πgolangci-lint run
π¨ (install golangci-lint here)go run ./docs/docs.go
and committing the changes π