Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate readme yaml #3

Merged
merged 3 commits into from
Jul 27, 2018
Merged

Migrate readme yaml #3

merged 3 commits into from
Jul 27, 2018

Conversation

vadim-gleif
Copy link
Contributor

what

  • Add README.yaml

why

  • Standardize README

@vadim-gleif vadim-gleif requested review from sarkis and osterman July 18, 2018 14:05
README.yaml Outdated
url: "https://slack.cloudposse.com"

related:
- name: "/terraform-aws-acm-request-certificate"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove /

README.yaml Outdated
- name: "/terraform-aws-acm-request-certificate"
description: "Terraform module to request an ACM certificate for a domain name and create a CNAME record in the DNS zone to complete certificate validation"
url: "https://github.com/cloudposse/terraform-aws-acm-request-certificate"
- name: "terraform-aws-alb"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related

image: "https://slack.cloudposse.com/badge.svg"
url: "https://slack.cloudposse.com"

related:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@osterman osterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments

@vadim-gleif vadim-gleif requested a review from osterman July 20, 2018 10:29
README.md Outdated
File a GitHub [issue](https://github.com/cloudposse/terraform-tls-ssh-key-pair/issues), send us an [email](mailto:[email protected]) or reach out to us on [Gitter](https://gitter.im/cloudposse/).
File a GitHub [issue](https://github.com/cloudposse/terraform-tls-ssh-key-pair/issues), send us an [email][email] or join our [Slack Community][slack].

## Commerical Support
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebuild

Copy link
Member

@osterman osterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebuild

@vadim-gleif vadim-gleif force-pushed the migrate-readme-yaml branch from a083176 to b4c0444 Compare July 23, 2018 11:25
@vadim-gleif vadim-gleif requested a review from osterman July 24, 2018 09:33
@osterman osterman merged commit 4cc285e into master Jul 27, 2018
@osterman osterman deleted the migrate-readme-yaml branch July 27, 2018 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants