Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default block response to the default block block #54

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

mfuhrmeisterDM
Copy link
Contributor

what

We want to be able to set the default response header for the default action if this is set to block.

why

We face the problem that without a default response code some requests are not blocked. Even if AWS says that the default is 403.
We solved this by setting the response code manually to 403.

references

@mfuhrmeisterDM mfuhrmeisterDM requested review from a team as code owners October 4, 2023 09:24
@aknysh
Copy link
Member

aknysh commented Oct 4, 2023

@mfuhrmeisterDM thank you.

Please run the following commands and commit the changes

make init
make github/init
make readme

@mfuhrmeisterDM
Copy link
Contributor Author

@mfuhrmeisterDM thank you.

Please run the following commands and commit the changes

make init
make github/init
make readme

done

@aknysh
Copy link
Member

aknysh commented Oct 4, 2023

/terratest

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants