Update exclude_rule for Deprecations, Add Custom Response Body, Allow oversize_handling Option
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test all |
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
|
/rebuild-readme |
|
/test all |
…esponse body option
…rm-aws-waf into allowed_managed_rules
milldr
changed the title
action_to_use allow with Managed Rule Group Statement Rulesexclude_rule for Deprecations, Add Custom Response Body, Allow oversize_handling Option
…rm-aws-waf into allowed_managed_rules
|
/test all |
…rm-aws-waf into allowed_managed_rules
milldr
commented
Mar 31, 2023
| @@ -576,11 +596,29 @@ resource "aws_wafv2_web_acl" "default" { | |||
| content { | |||
| arn = rule_group_reference_statement.value.arn | |||
|
|
|||
| dynamic "excluded_rule" { | |||
| for_each = lookup(rule_group_reference_statement.value, "excluded_rule", null) != null ? toset(rule_group_reference_statement.value.excluded_rule) : [] | |||
| dynamic "rule_action_override" { | |||
There was a problem hiding this comment.
leave excluded_rule as is to prevent breaking change, and instead add new option for rule_action_override
max-lobur
previously approved these changes
Jun 21, 2023
|
/terratest |
Closed
max-lobur
reviewed
Jun 21, 2023
| name = rule_action_override.key | ||
| action_to_use { | ||
| dynamic "allow" { | ||
| for_each = rule_action_override.value.action == "allow" ? [1] : [] |
There was a problem hiding this comment.
Fails tests with "action" missing attribute in a map
aknysh
reviewed
Jul 6, 2023
| dynamic "excluded_rule" { | ||
| for_each = lookup(managed_rule_group_statement.value, "excluded_rule", null) != null ? toset(managed_rule_group_statement.value.excluded_rule) : [] | ||
| dynamic "rule_action_override" { | ||
| for_each = lookup(managed_rule_group_statement.value, "excluded_rule", null) != null ? managed_rule_group_statement.value.excluded_rule : {} |
There was a problem hiding this comment.
Suggested change
| for_each = lookup(managed_rule_group_statement.value, "excluded_rule", null) != null ? managed_rule_group_statement.value.excluded_rule : {} | |
| for_each = lookup(managed_rule_group_statement.value, "rule_action_override", null) != null ? managed_rule_group_statement.value. rule_action_override : {} |
aknysh
reviewed
Jul 6, 2023
| dynamic "excluded_rule" { | ||
| for_each = lookup(rule_group_reference_statement.value, "excluded_rule", null) != null ? toset(rule_group_reference_statement.value.excluded_rule) : [] | ||
| dynamic "rule_action_override" { | ||
| for_each = lookup(rule_group_reference_statement.value, "excluded_rule", null) != null ? rule_group_reference_statement.value.excluded_rule : {} |
There was a problem hiding this comment.
Suggested change
| for_each = lookup(rule_group_reference_statement.value, "excluded_rule", null) != null ? rule_group_reference_statement.value.excluded_rule : {} | |
| for_each = lookup(rule_group_reference_statement.value, "rule_action_override", null) != null ? rule_group_reference_statement.value. rule_action_override : {} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE This change changes the variable for
excluded_rulein bothmanaged_rule_group_statement_rulesandrule_group_reference_statement_ruleswhat
exclude_ruleoption formanaged_rule_group_statement_rulesoversize_handingforsize_constraint_statement_ruleswhy
excluded_ruleis deprecated and instead we should be usingrule_action_overrideoversize_handlingdefaults toCONTINUE. We want to set this as an optionreferences