Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made necessary changes for worker node AL2023 in version 1.0.1 #180

Closed
wants to merge 1 commit into from

Conversation

Darsh8790
Copy link

what

Added changes for AL2023 worker node AMI based on version tag v1.0.0.

why

Currently, there are no changes for AL2023, even in the latest tag 2.12.0. The necessary modifications for AL2023 EKS worker nodes are not present.
The existing EKS nodes running Amazon Linux 2 have multiple vulnerabilities. To remediate these issues, we need to upgrade our EKS worker nodes to AL2023 worker nodes.

references

We have tested these changes in our infrastructure, and they are working well.
We request that these changes be merged and released as a new tag, 1.0.1, which will include all the updates up to tag 1.0.0, along with the changes for AL2023 worker nodes.

@Darsh8790 Darsh8790 requested review from a team as code owners May 20, 2024 09:34
@Darsh8790 Darsh8790 requested review from hans-d and jamengual May 20, 2024 09:34
Copy link

mergify bot commented May 20, 2024

💥 This pull request now has conflicts. Could you fix it @Darsh8790? 🙏

@mergify mergify bot added conflict This PR has conflicts triage Needs triage labels May 20, 2024
@Nuru Nuru added enhancement New feature or request do not merge Do not merge this PR, doing so would cause problems needs-test Needs testing needs-cloudposse Needs Cloud Posse assistance and removed triage Needs triage labels May 22, 2024
Copy link

mergify bot commented May 22, 2024

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

@Nuru
Copy link
Contributor

Nuru commented May 22, 2024

@Darsh8790 Thank you for this PR.

I appreciate how much work you put into this. However, we cannot accept it as-is. If you do not want to work on it further, I understand, and we will use this to guide our future support for AL2023.

The main issue I see right off the bat is that this PR effectively breaks support for any AMI family other than AL2023. We would want to maintain backward compatibility for any AMIs Amazon continues to support.

Also, for this particular module, we are not supporting changes to v1. Although in general we want to allow for modifications for old major versions, this module's v1 was never really solid enough for that. So we would want these modifications to be made to the current version, which as of this writing is v2.12.0. (Note that even if we made the changes to v1, we would want to maintain support for older AMIs.)

Let us know how you'd like to proceed.

@Nuru Nuru mentioned this pull request Jun 4, 2024
@QuentinBtd
Copy link

Working on #185 to add support of AL2023 with latest module version :)

@Nuru Nuru mentioned this pull request Jun 10, 2024
@Nuru Nuru closed this in #186 Jun 17, 2024
@mergify mergify bot removed conflict This PR has conflicts needs-cloudposse Needs Cloud Posse assistance labels Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Do not merge this PR, doing so would cause problems enhancement New feature or request needs-test Needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants