Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup for V2 release #118

Merged
merged 4 commits into from
May 23, 2022
Merged

Cleanup for V2 release #118

merged 4 commits into from
May 23, 2022

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented May 21, 2022 •
edited
Loading

what

  • Add updated documentation for migration to V2.0.0
  • Change default for ebs_optimized to true
  • Add tags to the output, supersedes and closes feat: add tags_all to the output #112
  • Fix the tag value for Auto Scaler tags that indicate taints

why

  • Convert to production Semantic Versioning
  • Best practice is to set ebs_optimized to true and it is the default for most instances, so it was a mistake to default it to false when the input was introduced
  • Requested feature
  • Taint effect was not being properly indicated

@Nuru Nuru requested review from a team as code owners May 21, 2022 23:51
@Nuru Nuru requested review from nitrocode and milldr May 21, 2022 23:51
@Nuru Nuru added the no-release Do not create a new release (wait for additional code changes) label May 21, 2022
@Nuru
Copy link
Contributor Author

Nuru commented May 21, 2022

/test all

@Nuru
Copy link
Contributor Author

Nuru commented May 21, 2022

/test all

@Nuru
Copy link
Contributor Author

Nuru commented May 22, 2022

/test all

@Nuru
Copy link
Contributor Author

Nuru commented May 22, 2022

/test all

aknysh
aknysh reviewed May 22, 2022
View reviewed changes
docs/migration-v1-v2.md Outdated Show resolved Hide resolved
aknysh
aknysh reviewed May 22, 2022
View reviewed changes
test/src/go.mod Outdated Show resolved Hide resolved
aknysh
aknysh reviewed May 22, 2022
View reviewed changes
main.tf Show resolved Hide resolved
aknysh
aknysh reviewed May 22, 2022
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nitpicks

@Nuru Nuru requested a review from aknysh May 23, 2022 00:38
@Nuru
Copy link
Contributor Author

Nuru commented May 23, 2022

/test all

@Nuru Nuru merged commit 0d9d6a2 into master May 23, 2022
@Nuru Nuru deleted the maintenance branch May 23, 2022 02:39
@Nuru Nuru mentioned this pull request May 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@nitrocode nitrocode Awaiting requested review from nitrocode nitrocode was automatically assigned from cloudposse/contributors

@milldr milldr Awaiting requested review from milldr milldr was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nuru @aknysh