Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding Fargate Profile name and Fargate Role name. Update Fargate Profile naming #26

Merged
merged 2 commits into from
May 24, 2022

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented May 24, 2022

what

  • Allow overriding Fargate Profile name and Fargate Role name
  • Add the provide Kubernetes namespace to the Fargate Profile name when it's derived from the context

why

  • Allow the caller of the module to specify the names of the Fargate Profile and Fargate IAM Role (instead of deriving them from the context)
  • Allow provisioning multiple Fargate Profiles into the same account (using the same context values) but for different Kubernetes namespaces

@aknysh aknysh self-assigned this May 24, 2022
@aknysh aknysh requested review from a team as code owners May 24, 2022 19:25
@aknysh
Copy link
Member Author

aknysh commented May 24, 2022

/test all

@aknysh aknysh merged commit 9ee484a into master May 24, 2022
@aknysh aknysh deleted the update-profile-name branch May 24, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants