Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update module versions. Update GitHub Actions. Update example and tests. Update README #25

Merged
merged 15 commits into from
May 24, 2022
Merged

Update module versions. Update GitHub Actions. Update example and tests. Update README #25

merged 15 commits into from
May 24, 2022

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented May 24, 2022 •
edited
Loading

what

  • Update module versions
  • Update GitHub Actions
  • Update example and tests
  • Update README

why

  • Keep up to date

test

Waiting for worker nodes to join the EKS cluster...
Creating Kubernetes deployment 'demo-deployment' in the 'default' namespace...
Created Kubernetes deployment "demo-deployment"
Node ip-172-16-127-184.us-east-2.compute.internal has joined the EKS cluster at 2022-05-24 07:59:51 +0000 UTC
Node ip-172-16-133-145.us-east-2.compute.internal has joined the EKS cluster at 2022-05-24 07:59:52 +0000 UTC
Node fargate-ip-172-16-34-128.us-east-2.compute.internal has joined the EKS cluster at 2022-05-24 08:01:26 +0000 UTC
All nodes have joined the EKS cluster
Listing deployments in namespace '"default"':
* Deployment 'demo-deployment' has 1 replica(s)
Deleting deployment 'demo-deployment' ...
Deleted deployment 'demo-deployment'

@aknysh aknysh added the major Breaking changes (or first stable release) label May 24, 2022
@aknysh aknysh self-assigned this May 24, 2022
@aknysh aknysh requested review from a team as code owners May 24, 2022 05:08
@aknysh
Copy link
Member Author

aknysh commented May 24, 2022

/test all

bridgecrew[bot]
bridgecrew bot reviewed May 24, 2022
View reviewed changes
Copy link

@bridgecrew bridgecrew bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment outdated

@aknysh
Copy link
Member Author

aknysh commented May 24, 2022

/test all

@aknysh
Copy link
Member Author

aknysh commented May 24, 2022

/test all

@aknysh
Copy link
Member Author

aknysh commented May 24, 2022

/test all

korenyoni
korenyoni previously approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@korenyoni korenyoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The bulk of this PR is just on tests and examples, which look good, and the changes to the module itself is just on enabled so giving this a rubber stamp.

@aknysh
Copy link
Member Author

aknysh commented May 24, 2022

/test all

bridgecrew[bot]
bridgecrew bot reviewed May 24, 2022
View reviewed changes
Copy link

@bridgecrew bridgecrew bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment outdated

@aknysh aknysh requested a review from korenyoni May 24, 2022 16:30
@aknysh aknysh merged commit 3d415f5 into master May 24, 2022
@aknysh aknysh deleted the update-to-latest branch May 24, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridgecrew bridgecrew[bot] bridgecrew[bot] left review comments

@korenyoni korenyoni korenyoni approved these changes

@osterman osterman Awaiting requested review from osterman

@goruha goruha Awaiting requested review from goruha

@mcalhoun mcalhoun Awaiting requested review from mcalhoun

@Nuru Nuru Awaiting requested review from Nuru

@nitrocode nitrocode Awaiting requested review from nitrocode

Assignees

@aknysh aknysh

Labels
major Breaking changes (or first stable release)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aknysh @korenyoni