Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use partition #19

Merged
merged 2 commits into from
Aug 27, 2021
Merged

Use partition #19

merged 2 commits into from
Aug 27, 2021

Conversation

nitrocode
Copy link
Member

what

  • Use partition

why

  • Govcloud

references

N/A

@nitrocode nitrocode added the patch A minor, backward compatible change label Aug 27, 2021
@nitrocode nitrocode requested review from a team as code owners August 27, 2021 18:22
@nitrocode nitrocode requested a review from a team as a code owner August 27, 2021 18:23
@nitrocode nitrocode requested review from max-lobur and florian0410 and removed request for a team August 27, 2021 18:23
@nitrocode
Copy link
Member Author

/test all

max-lobur
max-lobur approved these changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@max-lobur max-lobur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. Does it affect every ARN we have in modules?

@nitrocode
Copy link
Member Author

Wow. Does it affect every ARN we have in modules?

any of them that are hard coded

@nitrocode nitrocode merged commit 7138a77 into master Aug 27, 2021
@nitrocode nitrocode deleted the partition branch August 27, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-lobur max-lobur max-lobur approved these changes

@florian0410 florian0410 Awaiting requested review from florian0410

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitrocode @max-lobur @cloudpossebot