Fix count logic for ebs, make variable region non-required
#5
Conversation
|
Hey old friend! We’ll get this reviewed shortly. |
main.tf
Outdated
| @@ -90,7 +92,8 @@ resource "aws_instance" "default" { | |||
| delete_on_termination = "${var.delete_on_termination}" | |||
| } | |||
|
|
|||
| tags = "${merge(module.label.tags, map("instance_index", "${count.index}"))}" | |||
| tags = "${merge(module.label.tags, map("instance_index", "${count.index}"))}" | |||
| volume_tags = "${merge(module.label.tags, map("instance_index", "${count.index}"))}" | |||
There was a problem hiding this comment.
looks like volume_tags is not in use.
and it's the same as tags?
There was a problem hiding this comment.
nope, isn't a same. ltmgfy :)
volume_tags - (Optional) A mapping of tags to assign to the devices created by the instance at launch time.
in case of module it's rood device i.e. /
There was a problem hiding this comment.
@SweetOps
they are the same in the code, and volume_tags is not in use anywhere.
please review it
There was a problem hiding this comment.
tbh, I don't understand what you want to hear. Why the both of them have same tags? It is necessary for consistency e.g. instance with name cp-test-kafka-1 should has the same name for root device (cp-test-kafka-1) and same tags as instance to which it assigned.
There was a problem hiding this comment.
volume_tags has been removed due hashicorp/terraform#3531 (comment)
SweetOps
changed the title
region non-requiredregion non-required
|
I do not understand what this has to do with "hashicorp/terraform#3531", |
what
regionnon-required