Raised version of module for ssh_key_pair #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module is pointing to version 0.9.0. However 0.9.0 can only be used with Terraform version 0.12. Result is that this module is broken in 0.12.x+ versions, as you can see in the error that i used with a terraform version 0.13.x: ``` Error: Unsupported Terraform Core version on .terraform/modules/instance.ssh_key_pair/versions.tf line 2, in terraform: 2: required_version = "~> 0.12.0" ``` In later versions of the ssh_key_pair module this is fixed, so i raised this version right up to the latest available.
a-nldisr
requested review from
jhosteny and
RothAndrew
and removed request for
a team
|
/test all |
|
/rebuild-readme |
|
/test all |
RothAndrew
approved these changes
Oct 13, 2020
starcry
pushed a commit
to YouLend/terraform-aws-ec2-instance-group
that referenced
this pull request
Jun 9, 2022
* Raised version of module for ssh_key_pair This module is pointing to version 0.9.0. However 0.9.0 can only be used with Terraform version 0.12. Result is that this module is broken in 0.12.x+ versions, as you can see in the error that i used with a terraform version 0.13.x: ``` Error: Unsupported Terraform Core version on .terraform/modules/instance.ssh_key_pair/versions.tf line 2, in terraform: 2: required_version = "~> 0.12.0" ``` In later versions of the ssh_key_pair module this is fixed, so i raised this version right up to the latest available. * Updated README.md Co-authored-by: actions-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ssh_key_pair module is pointing to version 0.9.0. However 0.9.0 can only be used with Terraform version 0.12. Result is that this module is broken in 0.12.x+ versions, as you can see in the error that i used with a terraform version 0.13.x:
In later versions of the ssh_key_pair module this is fixed by this commit: cloudposse/terraform-aws-key-pair@fec52dc, so i raised this version right up to the latest available.