Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inspector is now enabled on deploy) #914

Merged
merged 2 commits into from
Nov 30, 2023
Merged

fix(inspector is now enabled on deploy) #914

merged 2 commits into from
Nov 30, 2023

Conversation

bradj
Copy link
Contributor

@bradj bradj commented Nov 30, 2023

what

  • enables Inspector on Delegated Admin and Member accounts

why

  • deployments would fail due to invoking account not being enabled

@bradj bradj requested review from a team as code owners November 30, 2023 00:45
mcalhoun
mcalhoun approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@mcalhoun mcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bradj bradj merged commit d19f639 into main Nov 30, 2023
3 checks passed
@bradj bradj deleted the fix/aws-inspector2 branch November 30, 2023 12:32
goruha pushed a commit to cloudposse-terraform-components/aws-inspector2 that referenced this pull request Nov 27, 2024
@bradj @cloudpossebot
fix(inspector is now enabled on deploy) (cloudposse/terraform-aws-com…
71ae243 
…ponents#914)

Co-authored-by: cloudpossebot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcalhoun mcalhoun mcalhoun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bradj @mcalhoun @cloudpossebot