Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing inputs to the wordpress example #62

Merged
merged 2 commits into from
Jun 7, 2021

Conversation

evertonevaristo
Copy link
Contributor

There are two missing properties in the locals dict,

cache_policy_id             = ""
origin_request_policy_id    = ""

what

  • Describe high-level what changed as a result of these commits (i.e. in plain-english, what do these changes mean?)
  • Use bullet points to be concise and to the point.

why

  • Provide the justifications for the changes (e.g. business case).
  • Describe why these changes were made (e.g. why do these commits fix the problem?)
  • Use bullet points to be concise and to the point.

references

  • Link to any supporting github issues or helpful documentation to add some context (e.g. stackoverflow).
  • Use closes #123, if this PR closes a GitHub issue #123

There are two missing properties in the locals dict, 

    cache_policy_id             = ""
    origin_request_policy_id    = ""
@evertonevaristo evertonevaristo requested review from a team as code owners May 31, 2021 15:17
@evertonevaristo evertonevaristo requested a review from a team as a code owner May 31, 2021 15:18
@nitrocode
Copy link
Member

/test all

@nitrocode
Copy link
Member

What are you trying to fix here? Is the example not working?

Do you mind filling out the what and the why in the PR template ? These explanations help give us some context.

@evertonevaristo
Copy link
Contributor Author

what
The example script will work as expected.

why
There's a lack of two parameters in the wordpress example...

cache_policy_id             = ""
origin_request_policy_id    = ""

@evertonevaristo
Copy link
Contributor Author

What are you trying to fix here? Is the example not working?

Do you mind filling out the what and the why in the PR template ? These explanations help give us some context.

Yes! the example isnt working... (it's my first commit on a public repo, so.. I'm really newbie on this...)

@nitrocode nitrocode changed the title Update main.tf Add missing inputs to the wordpress example Jun 7, 2021
@nitrocode nitrocode merged commit 0c9714d into cloudposse:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants