Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifiying force_destroy for s3-log-storage submodule #58

Merged
merged 2 commits into from
Mar 15, 2021
Merged

Allow specifiying force_destroy for s3-log-storage submodule #58

merged 2 commits into from
Mar 15, 2021

Conversation

joe-niland
Copy link
Member

what

  • Allow specifying force_destroy for s3-log-storage submodule
  • Add random id to module attributes to cause S3 log bucket to have a random name

why

  • Automated tests were failing due to duplicate names and non-empty buckets

references

  • None

@joe-niland joe-niland requested review from a team as code owners March 15, 2021 03:09
@joe-niland joe-niland mentioned this pull request Mar 15, 2021
Merged
@joe-niland
Copy link
Member Author

/test all

@joe-niland joe-niland merged commit dc5b7bd into cloudposse:master Mar 15, 2021
@joe-niland joe-niland deleted the pass-force-destroy-var-for-s3-logs branch March 15, 2021 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@adamcrews adamcrews Awaiting requested review from adamcrews

@RothAndrew RothAndrew Awaiting requested review from RothAndrew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joe-niland @aknysh