Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code to allow specification of bucket. #43

Merged
merged 2 commits into from
Oct 31, 2020
Merged

Add code to allow specification of bucket. #43

merged 2 commits into from
Oct 31, 2020

Conversation

krystan
Copy link
Contributor

@krystan krystan commented Oct 31, 2020 •
edited
Loading

what

  • Introduced variable to specify bucket to log to.

why

  • Allow centralised logging rather than log to the same account
  • They allow the log bucket to be specified rather than created in the same account by default.

references

@krystan krystan requested review from a team as code owners October 31, 2020 02:05
@krystan krystan requested review from Gowiem and danjbh October 31, 2020 02:05
@aknysh
Copy link
Member

aknysh commented Oct 31, 2020

/rebuild-readme

@aknysh
Copy link
Member

aknysh commented Oct 31, 2020

/test all

aknysh
aknysh approved these changes Oct 31, 2020
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @krystan

@aknysh aknysh merged commit 3427968 into cloudposse:master Oct 31, 2020
@krystan krystan deleted the feature/use_specified_bucket branch October 31, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem

@danjbh danjbh Awaiting requested review from danjbh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support an already created bucket for logging
2 participants
@krystan @aknysh