Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(output): Make sure "cf_aliases" won't fail if aliases not set #24

Merged
merged 1 commit into from
Apr 26, 2019
Merged

fix(output): Make sure "cf_aliases" won't fail if aliases not set #24

merged 1 commit into from
Apr 26, 2019

Conversation

k911
Copy link
Contributor

@k911 k911 commented Apr 18, 2019

When using dns_aliases_enabled = "false" and not setting var.aliases, terraform complains that attribute aws_cloudfront_distribution.default.aliases is not defined.

aknysh
aknysh approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @k911

@aknysh aknysh merged commit ddf9555 into cloudposse:master Apr 26, 2019
@k911 k911 deleted the fix/aliases branch April 26, 2019 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k911 @aknysh