Migrate readme yaml #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
reviewed
Jul 12, 2018
| image: "https://slack.cloudposse.com/badge.svg" | ||
| url: "https://slack.cloudposse.com" | ||
|
|
||
| related: |
There was a problem hiding this comment.
There was a problem hiding this comment.
Add this: https://github.com/cloudposse/terraform-root-modules/tree/master/aws/docs
description: "Reference implementation combining `terraform-aws-s3-website` with `terraform-aws-cdn`"
osterman
reviewed
Jul 13, 2018
README.yaml
Outdated
| - name: "terraform-aws-s3-website" | ||
| description: "Terraform module to provision S3-backed Websites" | ||
| url: "https://github.com/cloudposse/terraform-aws-s3-website" | ||
| - name: "terraform-root-modules-aws-docs" |
There was a problem hiding this comment.
let's rewrite this to terraform-root-modules/aws/docs
There was a problem hiding this comment.
(it's just a friendly name. usually module names work, but in this case, we should refer to it some other way for clarity.)
aknysh
previously approved these changes
Jul 27, 2018
aknysh
approved these changes
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
README.yamlwhy