pin to node 16 #54
Merged
pin to node 16 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
approved these changes
Jan 5, 2024
mcalhoun
added
the
no-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Pin the action to node 16
why
Currently the tests are using
nock, which interceptsfetchrequests and mocks them in the test enviornment. Node 18+ introduced thefetch APInatively and it brokenock. There is an issue opened withnockthat they hope to merge in January 2024 (this month at the time of writing). Once that is merged, we will bump to Node 20.references
nock/nock#2397