-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tf 0 12 support #12
Add tf 0 12 support #12
Conversation
@eversC this looks amazing! Thanks so much for biting the bullet and helping us upgrade this. |
@eversC this part looks suspect: should |
fixes #6 |
Hi @osterman 👋 , thanks for getting back to me so quickly.
That looks like a bit of an oversight on my part, as it does seem |
I made an additional commit, 2633d0e, which I believe fixes the I just updated the |
Yea, not improbable =) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Changed default version of terraform to 0.12. Will merge and cut a release. Thanks for this!
Adds support for terraform v0.12
On the face of it this will look like a tonne of changes so I'll make an attempt at summarising:
match
which holds all of the regex group matches fromretfplanline
. This wasn't exactly necessary but felt cleaner holding it all in its own structexpression
struct, which holds regexes that differ between versions of terraform.versionedExpressions
map which maps terraform version to anexpression
TFENV
so users can use tf 0.12 (defaults to tf 0.11)main_tests.go
In terms of testing, I've done a diff (see attached) of the outputs from running
make test
with tf 0.11 in the/tests
directory, on the latest binary you've released Vs. a binary I've built from my branch. I think it's come out well; just a few differences where the id of therandom_string.some_password
is different (which is fine).tf-011-old-vs-new-diff.txt
For what it's worth, I've also run
make test
with tf 0.12 (see attached output). This looks okay to me but might need some sanity checking.tf012_test.txt