-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for abc.abstract*
methods
#450
Conversation
Codecov Report
@@ Coverage Diff @@
## master #450 +/- ##
==========================================
+ Coverage 92.52% 92.56% +0.04%
==========================================
Files 4 4
Lines 709 713 +4
Branches 151 155 +4
==========================================
+ Hits 656 660 +4
Misses 32 32
Partials 21 21
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could you please document the change in the changelog?
Thanks for fixing this @jrbourbeau |
Thanks for reviewing @ogrisel @KristianHolsheimer -- just pushed up a changelog entry |
Just checking in here, @ogrisel is there anything else that should be added to this PR? |
Sounds like the changelog entry was all that was needed, which has since been added. So going to go ahead and merge. Though please let us know if we missed anything else and we can follow up :) |
Sorry for the lack of reply. Too many github notifications. Thanks for the PR @jrbourbeau and merging it @jakirkham. |
No worries. Know the feeling ;) |
Yeah, no worries at all -- you're in good company : ) |
This PR adds support for
abc.abstractproperty
,abc.abstractclassmethod
, andabc.abstractstaticmethod
. The changes here are mostly a duplicate of what was proposed in #369 by @KristianHolsheimer plus a copy of the tests added in #371, but using theabc.abstract*
methods. Additionally, this PR extendstest_abc
a bit to include coverage for abstract@property
s.As pointed out in #367 (comment), the
abc.abstract*
methods added here are now deprecated, but it seems reasonable to add support for them anyways as users will still run into them from time to time (xref #394)Closes #367