ENH: Support pickling dynamic Enum subclasses. #105
Conversation
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
+ Coverage 81.34% 82.16% +0.81%
==========================================
Files 2 2
Lines 563 583 +20
Branches 113 117 +4
==========================================
+ Hits 458 479 +21
Misses 75 75
+ Partials 30 29 -1
Continue to review full report at Codecov.
|
|
|
||
| This is what gets called to save enum members. | ||
| """ | ||
| self.save_reduce(getattr, (type(obj), obj.name)) |
There was a problem hiding this comment.
This is the only line that isn't covered by the test suite currently.
There was a problem hiding this comment.
Ah, good catch. It's easy enough to add coverage for this case if we decide we want this feature, though I'm not totally convinced it's a good idea because idiomatic usage of Enum involves lots of is comparisons, which will break silently if a user unpickles the same Enum multiple times.
|
I'm gonna close this for now. I think this is providing too big a footgun for too small a benefit. If someone comes along and really wants support for enums defined in |
#101
NOTE: I'm not totally convinced that we actually want to support dynamic Enums. See #101 (comment) for more discussion.