Update dependencies, disable yamllint, add welcome msg #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nihussmann
force-pushed
the
feature/welcome-config-message
branch
from
ee4d1c7 to
2b199b1
Compare
schnatterer
changed the title
schnatterer
changed the title
schnatterer
requested changes
Oct 1, 2024
There was a problem hiding this comment.
A lot of changes, but the code looks simple 👏
Please
- Update
CHANGELOG.md - have a look at my finding bellow and
- Either comment why we disabled yamllint (image no longer maintained), or we just switch to pipelinecomponents/yamllint image, which is still maintained? At some later point we might supply our own image that provides all binaries needed by this build lib to get rid of 3rd-party dependencies such as this.
I'm also wondering if it creating several PRs, one per feature would be easier to track. WDYT?
| @@ -342,6 +343,27 @@ protected String createBuildDescription(String pushedChanges) { | |||
| return description | |||
| } | |||
|
|
|||
| private printWelcomeAndConfigs(Map gitopsConfig){ | |||
|
|
|||
| print(""" | |||
There was a problem hiding this comment.
Fancy ASCII art 🥳
Did you try if that looks good in jenkins?
With increase zoom level here on GitHub the lines are shifted and unreadable.
I'm not sure, maybe using plain text would be less risky?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.