Normalize relative path for document-root on Windows #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Calling resolve() doesn't fully normalize relative path on Windows (in Node v0.11.x, see nodejs/node-v0.x-archive#7031 ), i.e. doesn't lowercase drive letter, while normalize() does, which causes paths resulting from calling normalize() and join() (depending on normalize()) to differ and to break comparisons. Fixes cloudhead#42.
phstc
added a commit
that referenced
this pull request
Jun 18, 2014
Normalize relative path for document-root on Windows
|
Thanks added to master! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling resolve() doesn't fully normalize relative path on Windows (in Node v0.11.x, see nodejs/node-v0.x-archive#7031 ), i.e. doesn't lowercase drive letter, while normalize() does, which causes paths resulting from calling normalize() and join() (depending on normalize()) to differ and to break comparisons.
Fixes #42.