Add a docker service using openldap/slapd #3228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhanik
force-pushed
the
pr/ldap-as-part-of-docker
branch
3 times, most recently
from
8201998 to
2405c1b
Compare
fhanik
force-pushed
the
pr/ldap-as-part-of-docker
branch
from
2405c1b to
31533d7
Compare
fhanik
force-pushed
the
pr/ldap-as-part-of-docker
branch
3 times, most recently
from
45cf16c to
4224087
Compare
coolgang123
approved these changes
Jan 13, 2025
|
@strehle I would like your approval here. Adding LDAP as a docker container so that developers can easily create and tear down LDAP schemas. |
strehle
reviewed
Jan 15, 2025
Currently used by the openldap service in docker compose
This service gets populated with the same data set as the in memory albeit, the InMemoryLDAPServer and slapd use two separate file for data now InMemoryLdapServer uses ./uaa/src/test/resources/ldap_init.ldif (same as before) docker-compose uses ./scripts/ldap/ldap_slapd_data.ldif (new, copy of ldap_init.ldif for now) docker-compose uses ./scripts/ldap/ldap_slapd_schema.ldif (new, copy of ldap_db_init.ldif for now)) The old scripts still use ./uaa/src/test/resources/ldap_db_init.ldif but will be removed in future PR
fhanik
force-pushed
the
pr/ldap-as-part-of-docker
branch
from
4224087 to
860ed17
Compare
|
@coolgang123 @fhanik you can merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of Test Confidence Journey
Reason for this PR: Turns out that once LDAP(openldap) started failing, some tests where rewritten and then those tests removed features that were tested. LDAP encryption with StartTLS was disabled. This PR provides the following
javax.net.debugflag to be set for integrationTestI would like to remove the
@EnabledIfProfileon so that integration tests always require LDAP and startTLS to be tested. This requires a modification to the Github test runners