Improve Performance of IdP Lookup during Password Grant #3161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nManager.authenticate
…dition checking for empty login hint
…y look up the single provider instead of all qualifying in the zone
…zed query is executed
adrianhoelzl-sap
force-pushed
the
improve-performance-of-idp-lookup-during-password-grant
branch
from
dd58a01 to
a87e775
Compare
strehle
added a commit
that referenced
this pull request
Nov 28, 2024
|
please have a look on Refactoring from #3165 this PR here increases the code complexity but I tried in #3165 to reduce complexity and removed the not needed interface: because we have the generic one with "IdentityProviderProvisioning identityProviderProvisioning" In 2nd PR I added your tests, see #3168 because for retrieveByOrigin it does not matter if externalOAuthProviderProvisioning or identityProviderProvisioning. |
strehle
added a commit
that referenced
this pull request
Nov 28, 2024
strehle
added a commit
that referenced
this pull request
Nov 29, 2024
|
closing in favor of #3165 |
adrianhoelzl-sap
deleted the
improve-performance-of-idp-lookup-during-password-grant
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize the lookup of IdPs during password grant flow: whenever "uaa" or "ldap" is used as a login hint, we no longer read all active IdPs in the identity zone but rather only the single one.