Sonar refactoring - IdentityProviderEndpoints class #2890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187603855 The labels on this github issue will be updated when the story is started. |
strehle
changed the title
Closed
…torIdp2 # Conflicts: # server/src/main/java/org/cloudfoundry/identity/uaa/provider/IdentityProviderEndpoints.java
hsinn0
reviewed
May 23, 2024
hsinn0
reviewed
May 24, 2024
| return new ResponseEntity<>(body, UNPROCESSABLE_ENTITY); | ||
| } | ||
| updatedIdp.setSerializeConfigRaw(rawConfig); | ||
| setAuthMethod(updatedIdp); | ||
| redactSensitiveData(updatedIdp); | ||
|
|
||
| return new ResponseEntity<>(updatedIdp, OK); | ||
| return new ResponseEntity<>(updatedIdp, status); |
There was a problem hiding this comment.
Does this not end up returning different status for the same result after this change?
There was a problem hiding this comment.
this part was a duplicated one, see
now an extra method persistIdentityProviderChange for create and update
server/src/main/java/org/cloudfoundry/identity/uaa/provider/IdentityProviderEndpoints.java
Show resolved
Hide resolved
|
@hsinn0 compare sonar findings from develop compared to this branch, see |
hsinn0
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
old:
https://sonarcloud.io/code?id=cloudfoundry-identity-parent&selected=cloudfoundry-identity-parent%3Aserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fcloudfoundry%2Fidentity%2Fuaa%2Fprovider%2FIdentityProviderEndpoints.java
vs.
new:
https://sonarcloud.io/code?id=cloudfoundry-identity-parent&pullRequest=2890&selected=cloudfoundry-identity-parent%3Aserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fcloudfoundry%2Fidentity%2Fuaa%2Fprovider%2FIdentityProviderEndpoints.java
Sonar:
https://sonarcloud.io/summary/new_code?id=cloudfoundry-identity-parent&pullRequest=2890
Did refactoring because of
x. The rest, e.g. logging or instance of are changes which came from plugins in IDE.